enhancement (CollaSet): support ResourceContext after CollaSet is del… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu8685
force-pushed
the
collaset-reclaim-resourcecontext
branch
from
5823841
to
8daa97b
Compare
shaofan-hs
reviewed
Aug 21, 2023
| return err | ||
| } | ||
|
|
||
| return controllerutils.RemoveFinalizer(context.TODO(), r, cls, preReclaimFinalizer) |
There was a problem hiding this comment.
Checking and removing finalizer can both be in or out this func together to avoid some confusing.
| podContext := &appsv1alpha1.ResourceContext{} | ||
| if err := c.Get(context.TODO(), types.NamespacedName{Namespace: instance.Namespace, Name: contextName}, podContext); err != nil { | ||
| if !errors.IsNotFound(err) { | ||
| return fmt.Errorf("fail to find ResourceContext %s/%s: %s", instance.Namespace, contextName, err) | ||
| } | ||
|
|
||
| if emptyOwnerIDs { |
There was a problem hiding this comment.
if len(ownedIDs) == 0 {
return nil
}
will be more simple.
| @@ -248,3 +266,20 @@ func (r *CollaSetReconciler) updateStatus(ctx context.Context, instance *appsv1a | |||
|
|
|||
| return err | |||
| } | |||
|
|
|||
| func (r *CollaSetReconciler) ensurePreReclaimFinalizer(cls *appsv1alpha1.CollaSet) (bool, error) { | |||
There was a problem hiding this comment.
What about adding another func EnsureFinalizer in package utils?
shaofan-hs
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eted
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.