-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement (CollaSet): support ResourceContext after CollaSet is del… #40
Conversation
5823841
to
8daa97b
Compare
return err | ||
} | ||
|
||
return controllerutils.RemoveFinalizer(context.TODO(), r, cls, preReclaimFinalizer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking and removing finalizer can both be in or out this func together to avoid some confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
podContext := &appsv1alpha1.ResourceContext{} | ||
if err := c.Get(context.TODO(), types.NamespacedName{Namespace: instance.Namespace, Name: contextName}, podContext); err != nil { | ||
if !errors.IsNotFound(err) { | ||
return fmt.Errorf("fail to find ResourceContext %s/%s: %s", instance.Namespace, contextName, err) | ||
} | ||
|
||
if emptyOwnerIDs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if len(ownedIDs) == 0 {
return nil
}
will be more simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -248,3 +266,20 @@ func (r *CollaSetReconciler) updateStatus(ctx context.Context, instance *appsv1a | |||
|
|||
return err | |||
} | |||
|
|||
func (r *CollaSetReconciler) ensurePreReclaimFinalizer(cls *appsv1alpha1.CollaSet) (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding another func EnsureFinalizer in package utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…eted
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.