-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaset respects PodOpsLifecycle label podopslifecycle.kusionstack.io/control #42
Conversation
|
||
func ControlByPodOpsLifecycle(obj client.Object) { | ||
if obj.GetLabels() == nil { | ||
obj.SetLabels(map[string]string{}) | ||
} | ||
|
||
if v, ok := obj.GetLabels()[v1alpha1.ControlledByPodOpsLifecycle]; !ok || v != "true" { | ||
obj.GetLabels()[v1alpha1.ControlledByPodOpsLifecycle] = "true" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ControlledByPodOpsLifecycle
and ControlByPodOpsLifecycle
path pkg/utils/common.go
-> pkg/controllers/utils/podopslifecycle/utils.go
may be more appropriat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ControlledByPodOpsLifecycle
andControlByPodOpsLifecycle
pathpkg/utils/common.go
->pkg/controllers/utils/podopslifecycle/utils.go
may be more appropriat
can't do it, because ControlledByPodOpsLifecycle
is also be imported in pkg/webhook
"fmt" | ||
corev1 "k8s.io/api/core/v1" | ||
"kusionstack.io/kafed/pkg/utils" | ||
"strconv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports are not sorted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
01bb50f
to
6c058b2
Compare
@Eikykun |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.