Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: 1,delete ruleset event channel 2, sync ruleset stage det… #53

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Aug 23, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

controller/ruleset
controller/podlifecycle

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun self-assigned this Aug 23, 2023
@Eikykun Eikykun added the kind/enhancement New feature or request label Aug 23, 2023
@Eikykun
Copy link
Member Author

Eikykun commented Aug 23, 2023

apis/apps/v1alpha1/well_known_annotations.go Outdated Show resolved Hide resolved
pkg/controllers/ruleset/ruleset_controller.go Outdated Show resolved Hide resolved
if err != nil {
return err
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just return err?

pkg/controllers/ruleset/checker/checker.go Outdated Show resolved Hide resolved
@shaofan-hs shaofan-hs merged commit b4cceb9 into main Aug 24, 2023
5 checks passed
@shaofan-hs shaofan-hs deleted the dev-230823-rs branch August 24, 2023 08:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants