Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enchancement: delete rs protector & make deploy in kind all in one & enable ruleset validate #65

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Aug 28, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

Makefile
controller/ruleset

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun changed the title enchancement: delete rs protector & make deploy in kind all in one enchancement: delete rs protector & make deploy in kind all in one & enable ruleset validate Aug 28, 2023
wu8685
wu8685 previously approved these changes Aug 28, 2023
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eikykun Eikykun self-assigned this Aug 28, 2023
@Eikykun Eikykun added the kind/enhancement New feature or request label Aug 28, 2023
@Eikykun Eikykun merged commit 19eef7c into main Aug 28, 2023
5 checks passed
@Eikykun Eikykun deleted the dev-230828-make branch August 28, 2023 09:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants