Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(CollaSet): add validation and defaulting for CollaSet #69

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

wu8685
Copy link
Collaborator

@wu8685 wu8685 commented Aug 28, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [] N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add validation and defaulting for CollaSet

@wu8685 wu8685 added kind/documentation Improvements or additions to documentation operating labels Aug 28, 2023
@wu8685 wu8685 self-assigned this Aug 28, 2023
@wu8685 wu8685 force-pushed the cls-validation branch 2 times, most recently from 223df33 to 757d300 Compare August 28, 2023 15:02
shaofan-hs
shaofan-hs previously approved these changes Aug 29, 2023

func (h *ValidatingHandler) validateUpdateStrategy(cls *appsv1alpha1.CollaSet, fSpec *field.Path) field.ErrorList {
var allErrs field.ErrorList
if cls.Spec.UpdateStrategy.PodUpdatePolicy != appsv1alpha1.CollaSetRecreatePodUpdateStrategyType &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch maybe more simple.

@wu8685 wu8685 merged commit 17bddbe into main Aug 29, 2023
5 checks passed
@wu8685 wu8685 deleted the cls-validation branch August 29, 2023 05:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
@wu8685 wu8685 added kind/enhancement New feature or request and removed kind/documentation Improvements or additions to documentation labels Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request operating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants