Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mixin for reconciler and webhook to inject fields #76

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

zoumo
Copy link
Collaborator

@zoumo zoumo commented Aug 29, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@WeichengWang1
Copy link
Collaborator

resource consist lgtm, good job

Makefile Outdated Show resolved Hide resolved
pkg/controllers/resourceconsist/consister.go Outdated Show resolved Hide resolved
test/e2e/scripts/kind-conf.yaml Outdated Show resolved Hide resolved
@wu8685
Copy link
Collaborator

wu8685 commented Aug 29, 2023

LGTM

@WeichengWang1 WeichengWang1 merged commit 19b2a68 into main Aug 29, 2023
5 checks passed
@WeichengWang1 WeichengWang1 deleted the logger branch August 29, 2023 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants