feat(CollaSet): supports operationDelaySeconds in Scaling-in and Updating Pods #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu8685
force-pushed
the
idle-period-support
branch
from
8f33df2
to
e96020f
Compare
wu8685
force-pushed
the
idle-period-support
branch
from
e96020f
to
bfe0cf8
Compare
| // update status anyway | ||
| if err := r.updateStatus(ctx, instance, newStatus); err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("fail to update status of CollaSet %s: %s", req, err) | ||
| return ctrl.Result{RequeueAfter: requeueAfter}, fmt.Errorf("fail to update status of CollaSet %s: %s", req, err) |
There was a problem hiding this comment.
%v should be used for req and err
| podWrappers, newStatus, syncErr := r.doSync(instance, updatedRevision, revisions, newStatus) | ||
| return calculateStatus(instance, newStatus, updatedRevision, podWrappers, syncErr), syncErr | ||
| func (r *CollaSetReconciler) DoReconcile(instance *appsv1alpha1.CollaSet, updatedRevision *appsv1.ControllerRevision, revisions []*appsv1.ControllerRevision, newStatus *appsv1alpha1.CollaSetStatus) (time.Duration, *appsv1alpha1.CollaSetStatus, error) { | ||
| podWrappers, newStatus, requeueAfter, syncErr := r.doSync(instance, updatedRevision, revisions, newStatus) |
There was a problem hiding this comment.
DoReconcile just call doSync, and doSync only called by DoReconcile, is it possible to merged DoReconcile and doSync to one func
WeichengWang1
approved these changes
Aug 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eration
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re FeatureRequest: CollaSet supports delaying a period before do scaling-in or updating Pods #78
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.