Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ruleset to podtransitionrule #96

Merged
merged 5 commits into from
Sep 25, 2023
Merged

rename ruleset to podtransitionrule #96

merged 5 commits into from
Sep 25, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Sep 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun marked this pull request as draft September 25, 2023 06:10
@Eikykun Eikykun requested review from shaofan-hs, wu8685 and zoumo and removed request for shaofan-hs and wu8685 September 25, 2023 08:21
@Eikykun Eikykun marked this pull request as ready for review September 25, 2023 08:21
@Eikykun Eikykun self-assigned this Sep 25, 2023
@Eikykun Eikykun added the kind/chore Updating grunt tasks etc; no production code change label Sep 25, 2023
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 14dc032 into main Sep 25, 2023
5 checks passed
@wu8685 wu8685 deleted the 230925-ruleset-rename branch September 25, 2023 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/chore Updating grunt tasks etc; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants