Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨🔥🍏 Replace incorrect runtime defaults #252

Merged
merged 2 commits into from
Apr 5, 2022
Merged

🎨🔥🍏 Replace incorrect runtime defaults #252

merged 2 commits into from
Apr 5, 2022

Conversation

evanroyrees
Copy link
Collaborator

@evanroyrees
🎨🔥🍏 Replace incorrect runtime defaults
a2d3631 
🍏🎨🔥 fixes #251
🍏🎨 Replace max_cpus oof 16 to 4 (actual default)
🍏🎨 Replace max_time of 2d to 240 h (actual default)
🍏🐳🎨 Bump version in manifest to 2.0.2
@evanroyrees evanroyrees added bug Something isn't working documentation Improvements or additions to documentation labels Apr 5, 2022
@evanroyrees evanroyrees requested a review from chasemc April 5, 2022 15:15
@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 79ce0c3

+| ✅  62 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/autometa/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/autometa/main/nextflow_schema.json
  • schema_description - No description provided in schema for parameter: plaintext_email
  • schema_description - No description provided in schema for parameter: custom_config_version
  • schema_description - No description provided in schema for parameter: custom_config_base
  • schema_description - No description provided in schema for parameter: hostnames
  • schema_description - No description provided in schema for parameter: show_hidden_params
  • schema_description - No description provided in schema for parameter: singularity_pull_docker_container

❔ Tests ignored:

  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_exist - File is ignored: .github/workflows/branch.yml
  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/nf-core-autometa_logo_light.png
  • files_exist - File is ignored: docs/usage.md
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo.png
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/bug_report.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/feature_request.md
  • nextflow_config - nextflow_config
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File does not exist: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File does not exist: assets/nf-core-autometa_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-autometa_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-autometa_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or foo
  • actions_ci - '.github/workflows/ci.yml' not found
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/Autometa/Autometa/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2022-04-05 15:22:16

chasemc
chasemc requested changes Apr 5, 2022
View reviewed changes
nextflow_schema.json Outdated Show resolved Hide resolved
@evanroyrees @chasemc
Update nextflow_schema.json
79ce0c3 
Co-authored-by: Chase Clark <18691127+chasemc@users.noreply.github.com>
@evanroyrees evanroyrees merged commit 5442af2 into dev Apr 5, 2022
@evanroyrees evanroyrees deleted the issue-251 branch April 5, 2022 15:34
evanroyrees added a commit that referenced this pull request Apr 7, 2022
@evanroyrees @chasemc
🎨🔥🍏 Replace incorrect runtime defaults (#252)
1a6c4b3 
* 🎨🔥🍏 Replace incorrect runtime defaults
* 
* 🍏🎨🔥 fixes #251
* 🍏🎨 Replace max_cpus oof 16 to 4 (actual default)
* 🍏🎨 Replace max_time of 2d to 240 h (actual default)
* 🍏🐳🎨 Bump version in manifest to 2.0.2

Co-authored-by: Chase Clark <18691127+chasemc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasemc chasemc chasemc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanroyrees @chasemc