nr.gz database downloading bug #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lting in always downloading nr.gz.Fixed file path handling to be less arch specific and updated variables for readability.
evanroyrees
added
the
hotfix
jason-c-kwan
reviewed
Apr 2, 2020
|
This has not been performance tested outside of running the script to see if any error messages were emitted. |
|
Do you at least know if the error is corrected? From looking through the code it seems to look for nr.gz.md5 now instead of nr.dmnd.md5. Is that correct? |
|
There exists an nr.gz checksum on NCBI's FTP server (See here nr.gz.md5 Where the diamond formatted database checksum is not hosted anywhere. |
|
OK, well after I merge, please check with the user that this fixes their problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_dbswhere autometa will loook fornr.dmnd.md5and if it is not found, will update nr. However, when nr is updated, the nr.dmnd.md5 is never written.