Option for using persistent notifications #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all, thank you for creating One Second Diary ! I use it almost every day and I really like its concept.
The goal of the PR is to add an option for using persistent notifications (see the related issue).
I've added the "usePersistentNotifications" key to the English and French translation files. I don't know how to translate it into other languages. You may need to add a commit to add this key to the other translation files.
I had to add code to close the persistent notification and reschedule it when a daily entry is added, as the persistent notification cannot be cancelled by the user. I moved some methods from SwitchNotificationsComponent to NotificationService for this purpose.
For information I initially wanted to reschedule notifications to the next day when an entry is added, to make this case not possible:
I wasn't able to prevent this to happen, as the flutter_local_notification package doesn't allow to specify an initial date for "time" notifications. However, I managed to close the notification when the user opens the application if a video has already been recorded for the current day.
Checklist
Before you create this PR, please confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.CHANGELOG.md
.CONTRIBUTORS.md
file, if it wasn't already present.