Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Update League Client To Use ClientServices Launcher, API Tweaks #218

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

Kyrluckechuck
Copy link
Owner

Description

Some long overdue updates since I haven't been using this for the last while, but have been for the last couple event passes.

  • Updates the league app to launch via the RiotClientServices.exe launch call, the same way that the League of Legends shortcut would launch the game. This should fix most scenarios which would open either the Riot Client or other sub-clients and launches League directly.
    • As part of this, we now try to parse out the Riot Client install location as well. Since there is no obvious registry entries for it (at least that I could find), I opted to parse it out of the League client uninstaller path.
      • If this eventually stops working and another path / reliable detection method isn't added, we may just swap to hard-coding this and making it so the bot user has to specify the override if they want it to work on non-standard install locations
  • On that note, I updated what the league & riot install override settings are since there are two now
  • Fixed edge case in Status API where the status would not be returned as expected and would then crash out instead of following the abort flow like it should

@akshualy
Copy link
Collaborator

LGTM :) Thanks for the effort!

@akshualy akshualy merged commit 6a51467 into main Nov 12, 2023
5 checks passed
@akshualy akshualy deleted the overdue-updates branch November 12, 2023 22:38
@akshualy
Copy link
Collaborator

Small side note, we really need to start writing a script to update the trait pictures, i really can not be bothered lol

@Kyrluckechuck
Copy link
Owner Author

Small side note, we really need to start writing a script to update the trait pictures, i really can not be bothered lol

100% agreed, though so long as it's once a set or two it's not too big of a deal to me 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants