Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/routing algorithm #17

Merged
merged 15 commits into from
Nov 25, 2019
Merged

Conversation

RomanKrajewski
Copy link
Collaborator

Erster Stand des Routing Algorithmus.

Copy link
Collaborator

@jakubprogramming jakubprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man könnte ggf. die alten dummy PolyLines welche ich zuvor beispielhaft implementiert habe aus dem Code löschen. Ich denke nicht das wir diese noch benötigen. Ist aber auch erstmal nicht so wichtig.

Ansonsten find ich das ganze ganz fantastisch!

Kann von mir aus gern in develop gemerged werden.

@RomanKrajewski
Copy link
Collaborator Author

Ja die werden eh überschrieben, sobald die richtige route geladen wurde, können auf jeden fall raus.

@mayo-s
Copy link
Collaborator

mayo-s commented Nov 18, 2019

Looking really good.
Only 2 things (@RomanKrajewski ):
Is there a reason for an unused cupertino.dart import?
Also please merge recent changes from develop and move osmdata.dart into services directory.

Will merge to develop when done.

@RomanKrajewski
Copy link
Collaborator Author

Hab die Änderungen zu den Anmerkungen durchgeführt

@RomanKrajewski RomanKrajewski merged commit f2f2b83 into develop Nov 25, 2019
This was referenced Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants