change colour space from RGB8 to the expected BGR8 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jondave @gcielniak @LeonardoGuevara @pulver22 Did you never have this problem with the gazebo sim I described in #21? I think this fix is needed! |
|
We weren't aware of this since we are not using point clouds for our module but I can see this fixes the problem you mentioned. |
|
As Leonardo said we only used the RGB camera, not the depth camera's pointcloud so I never noticed the colour difference. |
|
so,.you approve? |
|
Yes |
|
hang on, you closed without merging?? |
|
My bad, I merged it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
change the colour space of the simulated gazebo camera from RGB8 to BGR8, as is expected by the standard for pointclouds (and more generally).
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
With this in place, RViz2 shows the correct red and blue colours both in image view and in pointcloud:
[optional] Are there any post deployment tasks we need to perform?
rebuild and deploy the https://github.com/LCAS/teaching image when this is fixed.