Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependencies and minor package.xml fixes for simulation #25

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

marc-hanheide
Copy link
Member

Update package.xml with detailed description, maintainer info, and license; add new dependencies that were missing

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

We must get better at declaring dependencies and more generally providing correct package.xml files. This particular fix was needed as @gcielniak reported the simulation in the devcontainer of https://github.com/LCAS/ROB2002/ not having the sensor topics as the gazebo_plugins were not declared.

QA Instructions, Screenshots, Recordings

@gcielniak to try if his simulation now works

…cense; add new dependencies that were missing
@marc-hanheide marc-hanheide added the bug Something isn't working label Sep 20, 2024
@gcielniak gcielniak merged commit ddbdf64 into humble Sep 20, 2024
@gcielniak gcielniak deleted the fix_gazebo_plugins branch September 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants