Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes parameters leading to instabilities in simple.world #7

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

gcielniak
Copy link
Collaborator

No description provided.

@gcielniak
Copy link
Collaborator Author

Hi @marc-hanheide, one of the actions fails as it requires some login information. Could you please check?

@marc-hanheide
Copy link
Member

building fails because of it coming from a fork: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

If it were from a branch it works. Safety feature. feel free to merge anyway

Copy link
Member

@marc-hanheide marc-hanheide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcielniak gcielniak merged commit f9af7f7 into LCAS:humble Nov 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants