Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null gacs. #178

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Remove null gacs. #178

merged 1 commit into from
Jan 20, 2022

Conversation

justinlittman
Copy link
Contributor

Why was this change made?

$ exe/rdf2marc https://api.stage.sinopia.io/resource/d034cef5-f8d8-428b-86ae-2295da5be6cc
W, [2022-01-20T09:53:43.774704 #49211]  WARN -- : Could not get GAC for http://id.loc.gov/authorities/subjects/sh85074879 since missing field 043.
Traceback (most recent call last):
	6: from exe/rdf2marc:16:in `<main>'
	5: from /Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/converter.rb:13:in `convert'
	4: from /Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/rdf2model.rb:8:in `to_model'
	3: from /Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/rdf2model/mapper.rb:14:in `generate'
	2: from /Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/rdf2model/mappers/number_and_code_fields.rb:14:in `generate'
	1: from /Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/rdf2model/mappers/number_and_code_fields.rb:113:in `geographic_area_codes'
/Users/jlittman/data/ld4p/rdf2marc/lib/rdf2marc/rdf2model/mappers/number_and_code_fields.rb:113:in `sort': comparison of String with nil failed (ArgumentError)

How was this change tested?

Locally

Which documentation and/or configurations were updated?

@jermnelson jermnelson merged commit 6af624f into main Jan 20, 2022
@jermnelson jermnelson deleted the justinlittman-patch-1 branch January 20, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants