Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyTemplateOutline, ResourceTemplateForm False Positive Tests Clean-up #496

Closed
jermnelson opened this issue May 2, 2019 · 0 comments · Fixed by #523
Closed

PropertyTemplateOutline, ResourceTemplateForm False Positive Tests Clean-up #496

jermnelson opened this issue May 2, 2019 · 0 comments · Fixed by #523
Assignees
Labels
debt Technical debt, either refactor or remove

Comments

@jermnelson
Copy link
Contributor

jermnelson commented May 2, 2019

Remove or refactor the following PropertyTemplateOutline.test.js tests:

All use an approach that is a failed attempted to 'inject' info to an inner method -- attempting to mimic the promises for a particular property template, I believe

PropertyTemplateOutline.test.js

ResourceTemplateForm.test.js

  • 'renders a lookup component'
  • 'renders a list component'
  • 'renders InputLiteral nested component (b/c we have a property of type "literal")'
  • 'renders error alert box'
@jermnelson jermnelson added debt Technical debt, either refactor or remove future labels May 2, 2019
@ndushay ndushay changed the title Component Tests Clean-up Component False Positive Tests Clean-up May 2, 2019
@ndushay ndushay changed the title Component False Positive Tests Clean-up PropertyTemplate Outline Positive Tests Clean-up May 2, 2019
@ndushay ndushay changed the title PropertyTemplate Outline Positive Tests Clean-up PropertyTemplateOutline False Positive Tests Clean-up May 3, 2019
@ndushay ndushay changed the title PropertyTemplateOutline False Positive Tests Clean-up PropertyTemplateOutline, ResourceTemplateForm False Positive Tests Clean-up May 3, 2019
mjgiarlo added a commit that referenced this issue May 6, 2019
@mjgiarlo mjgiarlo self-assigned this May 6, 2019
@jgreben jgreben self-assigned this May 14, 2019
@ndushay ndushay removed the future label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt, either refactor or remove
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants