Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky renders incorrectly in KerbalVR apparently due to ocean renderer commandbuffer #225

Open
JonnyOThan opened this issue Nov 23, 2024 · 3 comments

Comments

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Nov 23, 2024

When using scatterer 0.0878 or 0.0880 with KerbalVR, the sky generally will appear black - unless you look up. There is a hard clipping line where the sky is drawn normally. I think I've tracked this down to some kind of problem with the ocean meshrenderer commandbuffer. The line that separates "good" from "bad" corresponds to where this command buffer draws into the depth/stencil buffer.

image

image

https://drive.google.com/file/d/1sm1NxsKQBWyqwqBKXCNrEf9JjYBC9QBl/view?usp=sharing

@JonnyOThan
Copy link
Contributor Author

Ooh, renderdoc had flagged some errors here and 2 of them are actually on the draw calls involved in the issue here:
image

@JonnyOThan
Copy link
Contributor Author

I think I have a fix for this, PR incoming shortly

JonnyOThan added a commit to JonnyOThan/Scatterer that referenced this issue Nov 23, 2024
… for ocean renderer

-fixes rendering in VR because it automatically gets the right size no matter what the camera dimensions are
-also doesn't require special screenshot handling
@LGhassen
Copy link
Owner

Changes sound good, thanks a lot. I'm in the middle of working on some other stuff for scatterer and it may be a while before I merge and release this, so feel free to distribute fixed dlls with kerbalVR in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants