Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the rust_2018_idioms lint as warning #171

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

hhirtz
Copy link
Member

@hhirtz hhirtz commented Jun 13, 2022

This should become the default in the future:
rust-lang/rust#54910

Reason this is put in lib.rs instead of CI: to ensure local invocations
of cargo build and cargo clippy pick up the warning.

Reason this is made a warning: so that code builds and runs anyway. On
the CI, the -D warnings clippy argument will treat it as a hard error.

This should become the default in the future:
rust-lang/rust#54910

Reason this is put in lib.rs instead of CI: to ensure local invocations
of cargo build and cargo clippy pick up the warning.

Reason this is made a warning: so that code builds and runs anyway. On
the CI, the `-D warnings` clippy argument will treat it as a hard error.
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #171 (bd9f9b1) into master (b6b1c43) will increase coverage by 0.02%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   50.66%   50.69%   +0.02%     
==========================================
  Files          41       41              
  Lines        7016     7019       +3     
==========================================
+ Hits         3555     3558       +3     
  Misses       3461     3461              
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/topology.rs 37.31% <33.33%> (ø)
src/algorithms/fiduccia_mattheyses.rs 89.88% <100.00%> (ø)
src/algorithms/graph_growth.rs 98.07% <100.00%> (ø)
src/algorithms/k_means.rs 80.25% <100.00%> (ø)
src/algorithms/kernighan_lin.rs 93.83% <100.00%> (ø)
src/algorithms/recursive_bisection.rs 92.48% <100.00%> (ø)
tools/src/bin/part-bench/main.rs 0.52% <0.00%> (-0.01%) ⬇️
src/algorithms/vn/first.rs 73.30% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b1c43...bd9f9b1. Read the comment docs.

@hhirtz hhirtz merged commit 48c2d88 into master Jun 13, 2022
@cedricchevalier19 cedricchevalier19 deleted the rust-2018-idioms branch June 22, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant