Skip to content

Commit

Permalink
cmd: consistently use -r shorthand for resource groups
Browse files Browse the repository at this point in the history
For historical reasons, we used -r for NFS and NVMe-oF, but -g for
iSCSI.

Deprecate -r and use -g everywhere.
  • Loading branch information
chrboe committed Apr 25, 2023
1 parent e0b2507 commit 5b0eb9a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmd/iscsi.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ high availability primitives.`,

cmd.Flags().StringVarP(&username, "username", "u", "", "Set the username to use for CHAP authentication")
cmd.Flags().StringVarP(&password, "password", "p", "", "Set the password to use for CHAP authentication")
cmd.Flags().StringVarP(&group, "resource-group", "g", "DfltRscGrp", "Set the LINSTOR resource group")
cmd.Flags().StringVarP(&group, "deprecated-resource-group", "g", "DfltRscGrp", "Set the LINSTOR resource group")
_ = cmd.Flags().MarkHidden("deprecated-resource-group")
_ = cmd.Flags().MarkShorthandDeprecated("deprecated-resource-group", "use -r instead")
cmd.Flags().StringVarP(&group, "resource-group", "r", "DfltRscGrp", "Set the LINSTOR resource group")
cmd.Flags().StringSliceVar(&allowedInitiators, "allowed-initiators", []string{}, "Restrict which initiator IQNs are allowed to connect to the target")
cmd.Flags().BoolVar(&grossSize, "gross", false, "Make all size options specify gross size, i.e. the actual space used on disk")

Expand Down

0 comments on commit 5b0eb9a

Please sign in to comment.