Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot restore: The current error message is not very helpful #10

Closed
rck opened this issue Oct 8, 2018 · 3 comments
Closed

Snapshot restore: The current error message is not very helpful #10

rck opened this issue Oct 8, 2018 · 3 comments
Labels
wontfix This will not be worked on

Comments

@rck
Copy link
Member

rck commented Oct 8, 2018

DRBD snapshot rollback is not implemented, please use 'linstor' to recover your data, use 'qm unlock' to unlock your VM at /usr/share/perl5/PVE/Storage/Custom/LINSTORPlugin.pm line 441

If it can't be done automatically, could it perhaps include some hints on how to do the rollback manually?

Originally posted by @elonen in #5 (comment)

@rck
Copy link
Member Author

rck commented Oct 8, 2018

Hm, the help on the CLI is pretty good and the users-guide for DRBD/LINSTOR is extensive. What exactly should we put there? The exact commands to restore it to a resource "foo"? To me that really is a non-issue. Improving help for a feature that is not even there because as of now we can't do it the "Proxmox way"? Sorry, IMO a waste of time. I split that out into its own issue, feel free to come up with a better message and send a PR.

Thanks, rck

@elonen
Copy link

elonen commented Oct 14, 2018

Any further pointers (beyond qm unlock) as to how it's supposed to be done would be nice.

I read the documentation and understood that the (only?) way to restore a snapshot with LINSTOR is to create a new resource, but it didn't seem very useful as I couldn't figure out how to attach restored copy (or any arbitrary resources) back into a VM (Proxmox tends to say "unable to parse lvm volume name"). Guess it would need to be renamed as "vm-NNN-disk-N", but there doesn't seem to be commands to rename resources in LINSTOR. I ended up dding contents back and forth, and recreating the whole virtual HDD volume. LINSTOR docs are indeed extensive, but Proxmox specific parts don't seem to cover this.

@rck
Copy link
Member Author

rck commented Oct 17, 2018

Currently the only way is to restore such a snapshot to a new DRBD resource. I'm sure I explained that in the release mail on our ML back then when it was still drbdmanage and not LINSTOR: This is whole thing is meant to be used in a total "last resort" scenario. When you are happy to get to the data somehow, to then copy it to an image or whatever. It is, as of now, not meant to be used regularly as part of normal operation.

This will change at some point when LINSTOR supports in place snapshot rollback. Then it will be possible to do proper Proxmox integration. Till then, basically don't even use it (except for such "last resort" scenarios). And that is also why I'm reluctant to document something that is essentially not ready to be used by the broader community. It is a) you know exactly what is (and what not), and you are able to use it, because you know Proxmox and LINSTOR well enough. Then you don't need additional help. b) You don't know that, then you should not use it.

As I hope this is now sufficiently explained, and we already have a "in place snapshots" tracking ticket, I close this one.

@rck rck closed this as completed Oct 17, 2018
@rck rck added the wontfix This will not be worked on label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants