Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore snapshot fails #5

Open
fab33 opened this issue Oct 3, 2018 · 8 comments
Open

Restore snapshot fails #5

fab33 opened this issue Oct 3, 2018 · 8 comments

Comments

@fab33
Copy link

fab33 commented Oct 3, 2018

Create a snapshot from Proxmox web gui works fine and we can list the snapshot with "drbdmanage list-snapshots" but when we try to restore the snapshot it fails with the message "snapshot restore is not implemented yet".

@rck
Copy link
Member

rck commented Oct 4, 2018

Where exactly didn't you understand what I told you? Can/Should I explain it again?

LINBIT/drbdmanage-proxmox#2

@rck rck closed this as completed Oct 4, 2018
@fab33
Copy link
Author

fab33 commented Oct 4, 2018

Ok, I just copy the issue from drbdmanage-proxmox but it's the same in linstor-proxmox. You can't restore snapshot from the GUI and it will be a great feature.

@rck
Copy link
Member

rck commented Oct 4, 2018

Good then, let's keep it open. I don't see it happen because of these fundamental differences between "restore in place", and "restore to a now resource". There are ways it could be implemented, but that first needs to happen in LINSTOR itself.

@rck rck reopened this Oct 4, 2018
@acidrop
Copy link

acidrop commented Oct 5, 2018

The traditional restore approach of PVE, is useless and very slow. If you want to restore a VM quickly, just use the command line. This is explained in the LINSTOR documentation.

@elonen
Copy link

elonen commented Oct 7, 2018

The current error message is not very helpful:
DRBD snapshot rollback is not implemented, please use 'linstor' to recover your data, use 'qm unlock' to unlock your VM at /usr/share/perl5/PVE/Storage/Custom/LINSTORPlugin.pm line 441

If it can't be done automatically, could it perhaps include some hints on how to do the rollback manually?

@rck
Copy link
Member

rck commented Oct 8, 2018

As an update to the whole "in place" vs. "new resource" topic: In place is now on the roadmap, so eventually this should be possible. (No, I don't know when exactly)

@greb-o
Copy link

greb-o commented Sep 5, 2019

Hello,
The implementation of the snapshot restore feature in the proxmox console would be of real interest. Now, do you have any idea about when this feature will be available?
thank you,

@rck
Copy link
Member

rck commented Sep 6, 2019

In contrast to DRBDManage, LINSTOR has (limited) support for rolling back snapshots. This fits Proxmox's model a lot better. With the new API/abstraction ob the current release and by using the REST-client, it should be pretty easy to code something usable. That said, I'm too busy with other projects to just work on it because it would be fun. Perl is never fun. So this has to wait for a) a contribution (I will obviously help getting patches in shape), or b) a customer that requests it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants