Dont rm -rf all the repos #27
Conversation
a different rev can have different submodules Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
@LK4D4 this should fix the issue with refetching the entire repositories each time. There is a new flag -clean-vcs to keep the previous behavior |
giuseppe
force-pushed
the
dont-rm-rf
branch
4 times, most recently
from
f28e861 to
abe5766
Compare
|
@giuseppe @runcom I really wonder if you should try https://github.com/rancher/trash instead. It keeps vcs cache and stuff and it's better fit for your vendoring model. It can read same config format, so you just need to replace vndr binary with trash. |
|
@LK4D4 yeah we can try that tool while waiting golang's without messing this repository :) thanks! |
|
@giuseppe we can use glide and glide-vc to keep vendoring in c/image (I think) |
|
thanks for your reply. I've added a patch to replace vndr with trash. @LK4D4 Still you might be interested in this patch series though, it makes vndr as fast as trash when the vendor repos are already available. |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
If the VCS doesn't support it (at the moment only git has the implementation), fallback to the previous rm -rf && clone. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
dont-rm-rf
branch
2 times, most recently
from
6c7f096 to
2835fde
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
@LK4D4 in case it might be useful to you, I've modified the patch to not change the current behaviour but an user needs to specify |
|
@giuseppe I'm reluctant to merge it because trash much better handles that use-case and I don't want to create illusion that vndr can be replacement in that case. |
No description provided.