Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for new BIP340: XOnly is always even #28

Merged
merged 6 commits into from
Sep 15, 2020
Merged

Update for new BIP340: XOnly is always even #28

merged 6 commits into from
Sep 15, 2020

Commits on Sep 15, 2020

  1. XOnly is always even Y 

    BIP340 recently changed to transform 32-byte xonly to even y public keys
consistently. I see no reason to keep the SquareY option as its not used
in Bitcoin anymore.
    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    61f6173 View commit details
    Browse the repository at this point in the history

  2. Create a hex module 

    - Implement encode and decode as explicit functions
- Move all hex stuff into the module
    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    68416e3 View commit details
    Browse the repository at this point in the history

  3. Update schnorr_fun to latest BIP340 implementation 

    - Use new csv test file
- Use new hex module from secp25kfun
    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    c3c5f4f View commit details
    Browse the repository at this point in the history

  4. Use new BIP340 domain separation scheme 

    Abandoned the old one (mention by real-or-random) to the one suggested
here:

sipa/bips#207 (comment)
    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    95de2e0 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    396bcde View commit details
    Browse the repository at this point in the history

  6. Drive by documentation fixup

    @LLFourn
    LLFourn committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0e45abc View commit details
    Browse the repository at this point in the history