Improvements to managed_ptr #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinson96
reviewed
Sep 16, 2020
|
Can we update sphinx documentation to explain this stuff? |
|
I've added sphinx documentation to explain about managed_ptr. |
davidbeckingsale
approved these changes
Sep 17, 2020
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds chai::unpack so that the user can specify when they want a ManagedArray or a managed_ptr to be unpacked when calling chai::make_managed. If chai::unpack is used, the host pointer will be extracted and passed to the host constructor of the object and the device pointer will be extracted and passed to the device constructor of the object. The current behavior of automatically detecting when to do this falls down in the case where some ManagedArrays/managed_ptrs should be unpacked and others should not be, particularly when implicit conversions are disabled.