Updates fmt sprintf patch for XL compiler based on accepted fmt PR

See: fmtlib/fmt#3256

src/thirdparty/axom/fmt/README

@@ -11,5 +11,5 @@ We also put fmt in the axom namespace to isolate it from other libraries that mi
 > find . -type f -regex .*[.]h$ -exec sed -i "s/fmt::/axom::fmt::/g" {} \;
 * Add `namespace axom { \` to `AXOM_FMT_BEGIN_NAMESPACE` in `fmt/core.h`
 * Add `}                \` to `AXOM_FMT_END_NAMESPACE` in `fmt/core.h`
-* Apply `src/thirdparty/axom/fmt/xl_clang.patch` -- bugfix for XL compiler
+* Apply `src/thirdparty/axom/fmt/xl_printf.patch` -- bugfix for XL compiler
 * Apply `src/thirdparty/axom/fmt/hipcc_long_double.patch` -- bugfix for dealing with `long double` type on EAS architecture with hip compiler

src/thirdparty/axom/fmt/format.h

@@ -3393,14 +3393,6 @@ template <typename Char> struct arg_formatter {
   const basic_format_specs<Char>& specs;
   locale_ref locale;
 
-  // BEGIN AXOM BUGFIX
-  arg_formatter(buffer_appender<Char> it, const basic_format_specs<Char>& s)
-  : out (it), specs (s) {}
-
-  arg_formatter(buffer_appender<Char> it, const basic_format_specs<Char>& s, locale_ref l)
-  : out (it), specs (s), locale (l) {}
-  // END AXOM BUGFIX
-
   template <typename T>
   AXOM_FMT_CONSTEXPR AXOM_FMT_INLINE auto operator()(T value) -> iterator {
     return detail::write(out, value, specs, locale);

src/thirdparty/axom/fmt/printf.h

@@ -220,6 +220,16 @@ template <typename Char> class printf_width_handler {
   }
 };
 
+// BEGIN AXOM BUGFIX
+// Workaround for a bug with the XL compiler when initializing
+// printf_arg_formatter's base class.
+template <typename Char>
+auto make_arg_formatter(buffer_appender<Char> iter, basic_format_specs<Char>& s)
+    -> arg_formatter<Char> {
+  return {iter, s, locale_ref()};
+}
+// END AXOM BUGFIX
+
 // The ``printf`` argument formatter.
 template <typename OutputIt, typename Char>
 class printf_arg_formatter : public arg_formatter<Char> {
@@ -237,10 +247,10 @@ class printf_arg_formatter : public arg_formatter<Char> {
   }
 
  public:
-  // BEGIN AXOM BUGFIX
+// BEGIN AXOM BUGFIX
   printf_arg_formatter(OutputIt iter, format_specs& s, context_type& ctx)
-      : base{iter, s}, context_(ctx) {}
-  // END AXOM BUGFIX
+      : base(make_arg_formatter(iter, s)), context_(ctx) {}
+// END AXOM BUGFIX
 
   OutputIt operator()(monostate value) { return base::operator()(value); }
 

src/thirdparty/axom/fmt/xl_printf.patch

@@ -0,0 +1,33 @@
+diff --git a/src/thirdparty/axom/fmt/printf.h b/src/thirdparty/axom/fmt/printf.h
+index 1c6f960a6..7f221d01b 100644
+--- a/src/thirdparty/axom/fmt/printf.h
++++ b/src/thirdparty/axom/fmt/printf.h
+@@ -220,6 +220,16 @@ template <typename Char> class printf_width_handler {
+   }
+ };
+
++// BEGIN AXOM BUGFIX
++// Workaround for a bug with the XL compiler when initializing
++// printf_arg_formatter's base class.
++template <typename Char>
++auto make_arg_formatter(buffer_appender<Char> iter, basic_format_specs<Char>& s)
++    -> arg_formatter<Char> {
++  return {iter, s, locale_ref()};
++}
++// END AXOM BUGFIX
++
+ // The ``printf`` argument formatter.
+ template <typename OutputIt, typename Char>
+ class printf_arg_formatter : public arg_formatter<Char> {
+@@ -237,8 +247,10 @@ class printf_arg_formatter : public arg_formatter<Char> {
+   }
+
+  public:
++// BEGIN AXOM BUGFIX
+   printf_arg_formatter(OutputIt iter, format_specs& s, context_type& ctx)
+-      : base{iter, s, locale_ref()}, context_(ctx) {}
++      : base(make_arg_formatter(iter, s)), context_(ctx) {}
++// END AXOM BUGFIX
+
+   OutputIt operator()(monostate value) { return base::operator()(value); }
+