Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent general tests from running while running benchmarks custom target #698

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

chapman39
Copy link
Contributor

@chapman39 chapman39 commented Sep 5, 2024

Issue

It is expected only benchmarks should run when executing make run_benchmarks.

The configuration -C option in add_custom_target prevents benchmarks from running while executing make test. However, all tests and benchmarks run while executing make run_benchmarks.

This PR

Adds a "Benchmark" label -L. This means now only benchmarks will run during make run_benchmarks. And make test remains to only run general tests, no benchmarks.

@chapman39 chapman39 added the bug label Sep 5, 2024
@chapman39 chapman39 self-assigned this Sep 5, 2024
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chapman39 !

Are there any docs to update? Or does this fall under general CMake usage?

@chapman39 chapman39 requested a review from kennyweiss September 6, 2024 00:18
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@white238
Copy link
Member

Thanks @chapman39 !

@white238 white238 merged commit 17189f6 into develop Sep 11, 2024
8 checks passed
@white238 white238 deleted the bugfix/chapman39/benchmark_label branch September 11, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants