-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rvalue get for tuples #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like this, but we need some tests here to ensure that the rvalue getters work as necessary. Probably not a ton to do there, but at least some basic "make_tuple(0).get()" or similar for a few different situations so we have a smoke test for this would make me a lot more comfortable it wont accidentally be broken down the line.
Of course, I'll add tests. |
One thing to note about this is that it requires changes to be made in RAJA, so it will cause a break in compatibility so this change can only be made when we update everything. Do we want to add this for the immanent release or wait until a later release? |
I think we should get these changes in for the release. |
Does it break any external APIs in raja? It's an ABI break because of the new overloads but if the API level at least at raja is ok I'm a lot less worried about the fallout. |
It breaks stuff related to |
That seems pretty reasonable. |
@MrBurmark, do you consider this good to go? Tests look pretty good, I would normally include some actual executable tests in with the static asserts but you have really good coverage there so we might be alright in this case. |
I'll add some executable tests if its what you would do. |
@trws I'm ok with this once the tests pass. |
Looks great! |
Here is my attempt to add support for rvalue forms of get with tuple.
This fixes #116.