-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to compare resources #148
Conversation
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
…NL/camp into feature/kab163/stream-compare
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
…NL/camp into feature/kab163/stream-compare
@trws , @mdavis36 , @rhornung67 - Any ideas how to move forward here? The sycl and windows docker tests are complaining about ambiguous overloads.. I get an error message similar to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments about comments. Plus, one earlier comment I made (about m_value
in ==
operator comment) still to address. Otherwise, this looks good.
No more comments. 😄
ASSERT_TRUE(r1 == r1); | ||
ASSERT_TRUE(r2 == r2); | ||
ASSERT_TRUE(s == s); | ||
ASSERT_TRUE(h == h); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be above, and there should be a != test.
This compare function will compare 2 different resources.
I need this because Umpire would like to add a resource aware pool, but in order to do that we need to know if the resources that are being passed into the pool per allocate call are the same or different. (We handle each case differently.)