Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static culibos issue #567 #568

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix static culibos issue #567 #568

merged 1 commit into from
Nov 4, 2022

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Nov 4, 2022

CMAKE cannot find/add culibos when static cuda library is used.
This PR adds the static culibos library manually into our cmake file.

CLOSE #567

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is a fix for #567 as reported. In output from @v-dobrev, there is a culibos library on the linking line as far as I can see. It looks more like broken CUDA SDK installation to me. Anyhow, this is harmless modification, so we can try :)

@cnpetra
Copy link
Collaborator

cnpetra commented Nov 4, 2022

I am not sure this is a fix for #567 as reported. In output from @v-dobrev, there is a culibos library on the linking line as far as I can see. It looks more like broken CUDA SDK installation to me. Anyhow, this is harmless modification, so we can try :)

@pelesh I do not see Veselin's output where culibos appears. Was this sent via email?

@pelesh
Copy link
Collaborator

pelesh commented Nov 4, 2022

@pelesh I do not see Veselin's output where culibos appears. Was this sent via email?

In @v-dobrev's last posting in #567, you need to scroll the link line to the left, it is close to the end of the line.

@nychiang
Copy link
Collaborator Author

nychiang commented Nov 4, 2022

I am not sure this is a fix for #567 as reported. In output from @v-dobrev, there is a culibos library on the linking line as far as I can see. It looks more like broken CUDA SDK installation to me. Anyhow, this is harmless modification, so we can try :)

@pelesh @cnpetra I have tried to reproduce the problem #567 on Lassen, and this PR can fix it. See the same problem reporting from [1]

@cnpetra cnpetra merged commit 4a23598 into develop Nov 4, 2022
@v-dobrev
Copy link
Member

v-dobrev commented Nov 4, 2022

I can confirm that this PR resolved the issue I reported in #567.

The problem there was that even though libculibos.a was on the link line, it was before libcurand_static.a -- the ordering of the libraries on the link line matters.

@cameronrutherford
Copy link
Collaborator

Very annoying that ordering of libraries on link line matters, but I agree that this was in the end a harmless change. I retroactively approve :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static CUDA build failure
5 participants