Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove copy from/to device methods in vector classes #587

Merged
merged 20 commits into from
Feb 2, 2023
Merged

remove copy from/to device methods in vector classes #587

merged 20 commits into from
Feb 2, 2023

Conversation

cnpetra
Copy link
Collaborator

@cnpetra cnpetra commented Jan 25, 2023 •
edited
Loading

  • Addresses issue removal of Vector::copyToDev and Vector::copyFromDev #581
  • (pre)processing bounds and constraints in hiopNlpFormulation (currently is done on host) is now exclusively done via hiopVector interface, which facilitates the porting of this processing to device (this will be done by a future PR)
  • instruments cuda vectors with execution spaces
  • provides implementation of a couple of copy methods for device-host transfers needed by the cuda vectors

@cnpetra cnpetra marked this pull request as draft January 25, 2023 22:19
@cnpetra cnpetra requested a review from nychiang January 31, 2023 21:45
@cnpetra cnpetra marked this pull request as ready for review January 31, 2023 21:45
nychiang
nychiang reviewed Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor issues.

src/ExecBackends/MemBackendUmpireImpl.hpp Outdated Show resolved Hide resolved
src/LinAlg/hiopVectorIntCuda.cpp Outdated Show resolved Hide resolved
src/LinAlg/hiopVectorCuda.cpp Show resolved Hide resolved
@cnpetra cnpetra merged commit d047558 into develop Feb 2, 2023
@cnpetra cnpetra deleted the remove-copytofromdev-dev branch June 30, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nychiang nychiang nychiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnpetra @nychiang