Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab pipeline refactor #597

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Gitlab pipeline refactor #597

merged 6 commits into from
Feb 13, 2023

Conversation

cameronrutherford
Copy link
Collaborator

@cameronrutherford cameronrutherford commented Feb 10, 2023

This will be the first of a few PRs to upgrade HiOp CI. This is just a refactor, but should be merged before we start debugging further. This refactor also breaks existing CI, and so it's a high priority to get this fixed and merged first before working on other features.

This PR separates each GitLab CI yaml into separate files, and prepares to implement posting of status from PNNL and ORNL GitLab to HiOp GitHub.

@nychiang you will have to go on to LLNL GitLab, and re-configure where CI looks for pipeline configuration. This should be in Settings -> CI/CD Settings -> General Pipelines -> CI/CD Configuration File. Just specify .gitlab/llnl-ci.yml as the file, and CI should be up and running again in this PR and future pipelines once people rebase.

This might break existing pipelines, and so we should merge and rebase this to get CI back online for other developers.

@cameronrutherford
Copy link
Collaborator Author

@nychiang you will also probably also have to re-trigger the pipeline for this branch if you were unable to get to this before the mirror was updated.

IMO we should also re-factor the LLNL configuration - if you make it so that your GitLab repo becomes a push mirror, you will get CI to trigger much faster. This is currently how PNNL CI is configured and would be in line with how I am going to deploy ORNL CI.

@nychiang
Copy link
Collaborator

@cameronrutherford I just updated CI configurations on LLNL gitlab. Can you push some changes to this branch and see if my change works?

@cameronrutherford
Copy link
Collaborator Author

@cameronrutherford I just updated CI configurations on LLNL gitlab. Can you push some changes to this branch and see if my change works?

I added an empty commit. Because you have a pull mirror, it will take a while for the pull mirror to update, and then the pipeline status will show up.

While I want to change to a push mirror to fix this, you can also try and debug the integration by manually updating the pull mirror, and running the pipeline manually if necessary. I would also recommend opening the pipeline in the pipeline editor on your GitLab in case there are any syntax issues that I introduced.

@cameronrutherford
Copy link
Collaborator Author

@nychiang looks like LLNL CI is now running and failing - something you can fix by looking at the job logs?

Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cameronrutherford and I just did a quick test on LLNL gitlab and everything works fine. Cheers!

@cnpetra cnpetra merged commit 6403beb into develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants