Patch two memory leaks that cause more leaks #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plugs some memory leaks.
Overall, I would strongly recommend replacing most if not all the raw pointers with
std::unique_ptr
.std::unique_ptr
has numerous benefits over raw pointers including:In the case of
dir_cv_
andres_cv_
, it's not clear to me why their pointers in the first place. IMHO, it seems like judicious use references instead of pointers could get rid of a variety of new/delete's or std::unique_ptr.