-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for interior face integrals #1223
Merged
Merged
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
f27a541
adding testing tool that generates all possible face orientations
samuelpmishLLNL 26766aa
fix AddTet to AddHex
samuelpmishLLNL 3a7c374
add InteriorFace fn, add some preliminary tests
samuelpmishLLNL bd2947b
fix linkage error in restriction helper function, setting up next tests
samuelpmishLLNL 044162f
trying to figure out how to get node positions/directions from mfem
samuelpmishLLNL d3529fa
decode hcurl dof orientations for face elements
samuelpmishLLNL 0e96c71
add exhaustive test suite of DG face dof agreement
samuelpmishLLNL f1de1c0
plumbing for the new integral type
samuelpmishLLNL dff154c
Merge branch 'develop' into mish2/dg_support
tupek2 53e88be
more plumbing for the new integral type
samuelpmishLLNL 2e25351
Merge branch 'mish2/dg_support' of github-work.com:LLNL/serac into mi…
samuelpmishLLNL 8f739f1
debugging segfault
samuelpmishLLNL 4bcd5e2
Merge branch 'develop' into mish2/dg_support
samuelpmishLLNL c006522
add new ctor for restriction that takes a Domain, fix two small bugs …
samuelpmishLLNL 51b9dae
add some tests for domain-based restriction operators
samuelpmishLLNL 5082552
include some checks for element restrictions over domains with Hcurl,…
samuelpmishLLNL 18af6c8
working on updating sparse matrix assembly
samuelpmishLLNL 1945881
more work on new sparse matrix assembly routine
samuelpmishLLNL 0bf2235
big changes to move ElementTestrictions into Domain classes
samuelpmishLLNL 6270797
fix bug in geometric factor kernel macro, fix some warnings
samuelpmishLLNL e21d752
update some functional tests to use Domains
samuelpmishLLNL e909e10
suppress warnings and fix bug in fespace construction
samuelpmishLLNL 5d4a093
fix the way the chain rule is computed internally in the interior fac…
samuelpmishLLNL 9a5156e
debugging element matrix calculation
samuelpmishLLNL 938f788
fix bug in element matrix calculation
samuelpmishLLNL a25b076
add interior face functions for triangle and placeholders for quad
samuelpmishLLNL 2923c9e
debugging diff in quadrilateral stiffness matrix calculation
samuelpmishLLNL 303625a
this one line change took me like 3 hours to find
samuelpmishLLNL 0e94619
plumb new element restrictions through QoI specialization of serac::F…
samuelpmishLLNL cf72418
updating some tests to use Domains, (rather than meshes) in calls to …
samuelpmishLLNL 1277916
Merge branch 'develop' into mish2/dg_support
samuelpmishLLNL c5032a5
fix #include order issues, updating more tests
samuelpmishLLNL 726804d
updating more tests
samuelpmishLLNL 686ea10
updating more tests
samuelpmishLLNL e615bed
guard against accessing retrictions that weren't needed by an integral
samuelpmishLLNL ce09966
update buckling and contact examples
samuelpmishLLNL e824db3
update more examples and tests, add convenience function for checking…
samuelpmishLLNL f78da84
updating heat_transfer module + tests, some other examples
samuelpmishLLNL 9f828b7
update addCustomDomainIntegral in solid mechanics module
samuelpmishLLNL e3a87d1
fix const issue
samuelpmishLLNL 9e43f72
more guarding against accesses to unnecessary restriction operators
samuelpmishLLNL b37b454
fix interpolate routines returning degenerate tensors, rather than `d…
samuelpmishLLNL a636054
fix mistakenly calling a function that wasn't defined
samuelpmishLLNL a20e7b9
simplify qfunction in dg test
samuelpmishLLNL af09e08
update more solid mechanics tests
samuelpmishLLNL db99e0e
add more tests
samuelpmishLLNL 080e0d0
fix indexing bug in element stiffness calculation on interior faces, …
samuelpmishLLNL 2bf54fb
add a lot of doxygen comments, trying to figure out how to add suppor…
samuelpmishLLNL 7905f46
fix bug where face orientations were not be applied when they should …
samuelpmishLLNL 88055d1
revert experimental change to ParGridfunctions in geometric factor ro…
samuelpmishLLNL a694fe1
fix bug where set operations on domains were not populating the mfem_…
samuelpmishLLNL 3365ae3
add error message when trying to use an unsupported integral configur…
samuelpmishLLNL 3234970
run dg test on one processor
samuelpmishLLNL e3a3fdd
Apply style updates
e5e4fa9
Merge branch 'develop' into mish2/dg_support
samuelpmishLLNL ada95fb
adjust some names, delete unused code
samuelpmishLLNL e868e9c
fix some integer conversion warnings on GCC
samuelpmishLLNL 76d1890
address some doxygen warnings
samuelpmishLLNL 11bed34
Apply style updates
22dc40b
explicitly add some headers to CMakeLists.txt
samuelpmishLLNL 3c8b96e
(blind) attempt to fix benchmark compilation errors
samuelpmishLLNL 8a65b76
Merge branch 'mish2/dg_support' of github-work.com:LLNL/serac into mi…
samuelpmishLLNL d1e255e
enable building benchmarks by directly specifying SERAC_ENABLE_BENCHM…
samuelpmishLLNL cae2d94
fix compilation error from missing namespace prefix in benchmarks
samuelpmishLLNL afb499a
Apply style updates
9c44026
temporarily disable lua integration tests
samuelpmishLLNL 989bca6
delete print statements
samuelpmishLLNL f374a7a
respond to Mike's PR feedback
samuelpmishLLNL 50d63c3
Merge branch 'mish2/dg_support' of github-work.com:LLNL/serac into mi…
samuelpmishLLNL 9db8634
Apply style updates
c9219f3
respond to Brandon's feedback
samuelpmishLLNL fb01e66
Merge branch 'develop' into mish2/dg_support
samuelpmishLLNL 7249be1
Apply style updates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
cmake_dependent_option
is admittedly weird I think it is okay as is.SERAC_ENABLE_BENCHMARKS
generally shouldn't be set explicitly unless you want to enable benchmarks yet disable Serac's. Simply setENABLE_BENCHMARKS
.SERAC_ENABLE_BENCHMARKS
can only be set ifENABLE_BENCHMARKS
isON
. IfENABLE_BENCHMARKS
isON
, it will automatically setSERAC_ENABLE_BENCHMARKS
toON
. OtherwiseSERAC_ENABLE_BENCHMARKS
is forced toOFF
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-add
cmake_dependent_option(SERAC_ENABLE_BENCHMARKS "Enable benchmark executables" ON "ENABLE_BENCHMARKS" OFF)