Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KelvinHelmholtz-2d_McNally.py #105

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Dec 12, 2021

mixing scale tracker had a typo in the reduced density -- rhoprof. it as using "nodes" from the last iteration of the loop at ln 364 instead of nodeL from the local loop.

mixing scale tracker had a typo in the reduced density -- rhoprof.  it as using "nodes" from the last iteration of the loop at ln 364 instead of nodeL from the local loop.
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- what do you see in the output now with this fix?

@jmikeowen jmikeowen merged commit edeca55 into develop Dec 13, 2021
@jmpearl
Copy link
Collaborator Author

jmpearl commented Dec 14, 2021

I didn't actually compare the output ke before/after I bet its a noticeable change though. I stumbled upon it when I was trying to do a mass-match distribution and the different nodelist resolutions were causing a run-time error

@jmpearl jmpearl deleted the bug-fix/Kelvin-Helmholtz branch December 14, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants