CMake build time TPLs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not building certain tpls.
corporate firewalls. Yeesh.
…ikeowen/spheral into feature/cmake-build-time-tpls
|
@ptsuji This is the PR for the new CMake system |
|
I still have to check out the latest, but I have one question -- are the stamp files (I think from PYB11) still being written to the source tree? |
|
@jmikeowen Nope they are generated into the build tree now. |
|
Awesome! I'll try to check it out soon... |
|
This is looking good! |
jmikeowen
pushed a commit
that referenced
this pull request
Aug 10, 2020
…ster * commit '56f119ed43c09c459689497396d6bb4ac19b7533': Added vector functions to the Python interface for boundary. Tightened Voronoi node tolerance by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the cmake system to build TPLs as build time targets along with other changes and bugfixes:
CMake Flags
SPHERAL_INSTALL_DIR : Unchanged. This is where any built TPL's and Spheral libs will be installed.
BUILD_TPL=On/Off : On by default, when off NO TPLs will be built, will search in default location for libs, otherwise user can define the TPL install directory to search.
<tpl-name>_BUILD=On/Off : On by default unless BUILD_TPL=Off. Define if user does not want to build a TPL.
<tpl-name>_DIR : absolute path to TPL install location. If this is not set, cmake will set to default/SPHERAL_INSTALL_DIR. This location can be set as a search location when not building or a specific Install location for the given TPL.
ENABLE_CXXONLY : Only build C++ shared libs.
ENABLE_STATIC_CXXONLY : Only build C++ static libs.