Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 feature tk fix #199

Merged
merged 3 commits into from
Mar 7, 2023
Merged

python3 feature tk fix #199

merged 3 commits into from
Mar 7, 2023

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Mar 7, 2023

Summary

  • This PR is a bugfix
  • It does the following:
    • Pulls in tk and tcl as external spack packages to build python 3 with on LC machines.
    • Fixes python cmake includes dir when tpls are built under the source directory.

@mdavis36 mdavis36 requested a review from jmikeowen March 7, 2023 22:35
jmikeowen
jmikeowen approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- good work here!

@jmikeowen jmikeowen merged commit 8b4e3ef into feature/Python3 Mar 7, 2023
mdavis36
mdavis36 commented Mar 7, 2023
View reviewed changes
cmake/spheral/SpheralAddLibs.cmake
OBJECT TRUE
)
target_include_directories(Spheral_${package_name} PRIVATE ${SPHERAL_INCLUDES})
target_include_directories(Spheral_${package_name} SYSTEM PRIVATE ${SPHERAL_EXTERN_INCLUDES})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmikeowen Oops, need to add this one back in on your branch otherwise Spheral doesn't pick up the polyclipper includes anymore

@mdavis36 mdavis36 deleted the feature/mdavis36/python3 branch July 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdavis36 @jmikeowen