Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for building on TOSS4 with spack v0.19.1. #200

Merged
merged 14 commits into from
Apr 19, 2023
Merged

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Mar 15, 2023

Summary

  • This PR is a feature
  • It does the following:
    • Enable Spheral to build on toss_4_x86_64_ib systems.
    • Increase allocation time for Lassen from default 60 min to 90
    • Reduce Number of CI jobs we store in spheral_builds dir.
    • Update Spack to v0.19.1
    • Increase the functionality of tpl-manager.py
      • --no-clean is enabled only by it's existence (Do not need to pass --no-clean true to enable)
      • --debug will run spack commands with the -d flag for returning debug output.
      • --no-spec will skip the spec step of tpl-manager and will not output the dependency tree.
    • Fix r-path runtime error when using additional TPLs, additional lib directories should be added to SPHERAL_ADDITIONAL_RPATHS.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#40)
  • LLNLSpheral PR has passed all tests.

@mdavis36 mdavis36 requested a review from jmikeowen April 13, 2023 18:41
jmikeowen
jmikeowen previously approved these changes Apr 13, 2023
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looking good to go

@mdavis36
Copy link
Collaborator Author

Okay @jmikeowen this is passing everywhere, can I get an approval to merge.

Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Perhaps we we should just link our own Qhull usage with the scipy provided one in a future change?

@mdavis36 mdavis36 merged commit 688a7b1 into develop Apr 19, 2023
@mdavis36 mdavis36 deleted the feature/toss4 branch April 19, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants