Adding zlib TPL #21
Merged
Adding zlib TPL #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikeowen
approved these changes
Aug 4, 2020
jmikeowen
pushed a commit
that referenced
this pull request
Nov 5, 2020
* commit '69e4dbfb2f474a0c9f1c60caf74022c12954fb2b': Fixes for downloading pip modules as a separate stage. Locking the version of numpy-stl that works with our Python 2.7.* series. Splitting up pip download and pip install as separate stages, so if the pip modules have already been downloaded we can skip that step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly adding zlib TPL to fix missing compress2 symbol when MPI=Off
This is necessary because MPI links it's own zlib in, so when compiling without MPI the zlib
compress2symbol is undefined.