Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/dem #228

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Bugfix/dem #228

merged 2 commits into from
Jun 30, 2023

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Jun 29, 2023 •
edited
Loading

Summary

  • This PR is a bugfix for the DEM module
  • It does the following:
    • adds apply/enforce ghost bc methods for moment of inertia field
    • adds restart methods to Linear Spring DEM phys package

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

jmpearl added 2 commits June 28, 2023 15:13
@jmpearl
DEM : momentum of inertia needed bc methods
b4c824c 
restart methods arent strictly necessary but should prevent bugs down the road
@jmpearl
DEM : missing callback to base class bc methods
697453a
@jmpearl jmpearl requested a review from jmikeowen June 29, 2023 16:05
@jmpearl jmpearl marked this pull request as ready for review June 29, 2023 16:05
@mdavis36 mdavis36 added this to the 2023.06.0 Release milestone Jun 29, 2023
jmikeowen
jmikeowen approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for tracking this down so quickly Jason.

@jmpearl jmpearl merged commit 8b88161 into develop Jun 30, 2023
@jmpearl jmpearl deleted the bugfix/DEM branch June 30, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.06.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jmpearl @jmikeowen @mdavis36