Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/demtests #243

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Bugfix/demtests #243

merged 7 commits into from
Nov 1, 2023

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Oct 19, 2023

Summary

  • Sean caught some errors in the DEM test scripts not included in the ats. This PR updates those scripts.
  • It does the following:
    • updates 3 DEM test scripts which were broken
    • Removes one duplicate DEM test script that was defunct
    • fixes the distance method of the RectangularPlanarSolidBoundary

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl jmpearl requested a review from jmikeowen October 19, 2023 15:19
@jmikeowen
Copy link
Collaborator

Overall these changes look good. My only request would be to replace the locally defined sign functions with the generic ones we provide in the Utilities directory.

@jmpearl jmpearl requested a review from jmikeowen November 1, 2023 10:52
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@jmpearl jmpearl merged commit 2c27bcd into develop Nov 1, 2023
@jmpearl jmpearl deleted the bugfix/DEMtests branch November 1, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants