Fix external PolyClipper and add dev build feature #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path outside of Spheral
…yClipper and import it like the other TPLs
…ot be the way we want to do it though
…LNLSpheral changes
…dated blt version
…d some CMake calls to use BLT functions
jmikeowen
previously approved these changes
Nov 1, 2023
…building individual shared libraries
…om when Clang and gfortran are used together
mdavis36
reviewed
Nov 6, 2023
cmake/spheral/SpheralAddLibs.cmake
Outdated
| if(NOT ENABLE_SHARED) | ||
| # Build static spheral C++ library | ||
| if(ENABLE_SHARED) | ||
| # Build shared spheral C++ library, currently unavailable |
There was a problem hiding this comment.
Why is this currently unavailable?
There was a problem hiding this comment.
That comment is old. I will remove it.
src/CXXTests/CMakeLists.txt
Outdated
Comment on lines
4
to
7
| if(ENABLE_TESTS AND NOT ENABLE_DEV_BUILD) | ||
| blt_add_executable( NAME spheral_cuda_test | ||
| SOURCES Spheral_CUDA_Test.cc | ||
| DEPENDS_ON Spheral_CXX ${spheral_blt_cxx_depends}) |
There was a problem hiding this comment.
Can we make this work with DEV_BUILD? We should be able to get the list of C++ libraries and make them a dependency right?
There was a problem hiding this comment.
We might be able to reproduce what we do
spheral/cmake/spheral/SpheralAddLibs.cmake
Line 212 in b4b6ec5
I just wasn't sure if it was necessary since dev build mode was a specific thing that shouldn't be used in most instances.
mdavis36
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToDo :
RELEASE_NOTES.mdwith notable changes.