Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include the git hash in the Spheral python banner #254

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Jan 12, 2024

Summary

  • This PR is a bugfix
  • It does the following:
    • Ensures the git hash is always displayed in the Spheral python banner

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#70)
  • LLNLSpheral PR has passed all tests.

@ldowen ldowen requested review from jmikeowen and mdavis36 January 12, 2024 18:45
@ldowen ldowen self-assigned this Jan 12, 2024
@mdavis36
Copy link
Collaborator

@ldowen @jmikeowen If this is ready, can we run a test install with a tag e.g. "risky-test" to ensure this works as intended on production installs.

@jmikeowen
Copy link
Collaborator

@mdavis36 @ldowen , I agree it would be great to test with a tag as Mike suggests. Can we do that still in the branch?

@mdavis36
Copy link
Collaborator

@ldowen @jmikeowen It will trigger the pipeline for a tag on any branch. We just need to go in and manually trigger the production jobs for the installation once the pipeline has started and completed the normal set of build and test jobs.

@mdavis36
Copy link
Collaborator

@ldowen @jmikeowen Looks good to go

davis291@ruby965(master):[~]: ml load Spheral/risky-test
davis291@ruby965(master):[~]: spheral -c "import Spheral"
/------------------------------------------------------------------------------\
|  Spheral version             : risky-test b30b4fb3d HEAD                     |
|    number of MPI tasks       : 1                                             |
|    number of threads per rank: 56                                            |
\------------------------------------------------------------------------------/

@ldowen ldowen merged commit 04b32f2 into develop Jan 18, 2024
1 check passed
@mdavis36 mdavis36 linked an issue Jan 18, 2024 that may be closed by this pull request
@mdavis36 mdavis36 added this to the 2024.01.0 Release milestone Jan 18, 2024
@ldowen ldowen deleted the bugfix/add_banner_hash branch January 18, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spheral banner & CMake git dependency
3 participants