Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make_policy.hh to the DataBase CMakeList.txt #260

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Jan 30, 2024

Summary

  • This PR is a bugfix
  • It does the following:
    • Adds the make_policy.hh file to CMakeList.txt in DataBase.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@ldowen ldowen requested review from jmikeowen and mdavis36 January 30, 2024 18:50
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- we really need some way to check when these sorts of header files are missed in the CMake files.

@mdavis36 mdavis36 added this to the 2024.01.1 Patch Release milestone Feb 2, 2024
@ldowen ldowen merged commit 684aedf into develop Feb 5, 2024
1 check passed
@ldowen ldowen deleted the bugfix/add_missing_header_files branch February 5, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants