Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some initialization problems with the damage models volume definitions. #264

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fixes some initialization problems with the damage models volume definitions. #264

merged 2 commits into from
Feb 12, 2024

Conversation

jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented Feb 9, 2024 •
edited
Loading

Summary

  • This PR is a bugfix
  • It does the following:
    • The damage model constructors had an oversight when computing the initial volume for seeding the flaw distributions in the presence of porosity. The volume of each point for this purpose should be just the volume of the solid material, not counting pore space.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen
The damage model constructors had an oversight when computing the
c17446e 
initial volume for seeding the flaw distributions in the presence of
porosity.  The volume of each point for this purpose should be just
the volume of the solid material, not counting pore space.
@jmikeowen
Updating release notes
ccc2d61
@jmikeowen jmikeowen requested a review from jmpearl February 9, 2024 19:12
@jmikeowen jmikeowen self-assigned this Feb 9, 2024
jmpearl
jmpearl reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@jmpearl jmpearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go

@jmikeowen jmikeowen merged commit dcd1080 into develop Feb 12, 2024
1 check passed
@jmikeowen jmikeowen deleted the bugfix/domainParallelism branch February 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpearl jmpearl jmpearl approved these changes

Assignees

@jmikeowen jmikeowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikeowen @jmpearl