Fixing conduit and axom external project src directory. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikeowen
approved these changes
Dec 4, 2020
|
I tried it with 3.12 as that is the closest on LC. The 3.10 documentation shows the SOURCE_SUBDIR command is available (so this should work as expected). I can give this a go later in a WSL2 build but I don't have that environment set up on any of my systems, so it may be a little. |
|
Yeah, I actually tried the old way with CMake 3.12 on LC and it worked too. I'll try to test a standard Ubuntu install in WSL2 as well and see if the default 3.10 works now. If so I'll amend the build instructions. |
MishaZakharchanka
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should help with the conduit configure errors some people were seeing.