Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building.rst #48

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Update building.rst #48

merged 1 commit into from
Jan 22, 2021

Conversation

as1m0n
Copy link
Contributor

@as1m0n as1m0n commented Jan 20, 2021

  1. Changed "chdir" to more universal "cd"
  2. changed ../../spheral to ../../Spheral to match current setup

@jmikeowen
Copy link
Collaborator

The "cd" change seems reasonable (this is shell dependent, but probably more folks are using bash these days). But the default clone of Spheral drops in a directory called "spheral" with the lower-case s doesn't it?

@as1m0n
Copy link
Contributor Author

as1m0n commented Jan 21, 2021 via email

@as1m0n
Copy link
Contributor Author

as1m0n commented Jan 21, 2021 via email

@jmikeowen
Copy link
Collaborator

Ah, I see the difference. If you use the clone command that the GitHub site offers up on the "Download" button, it comes out lower-case. But, because I wrote the upper-case Spheral in the docs you're getting it that way. This makes your change to the docs more consistent, so we should stick with that.

Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more consistent with bash, which is a common shell, so looks good.

@jmikeowen jmikeowen merged commit e12c078 into LLNL:develop Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants