Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/timer fixes #73

Merged
merged 5 commits into from
Jun 28, 2021
Merged

Feature/timer fixes #73

merged 5 commits into from
Jun 28, 2021

Conversation

jmikeowen
Copy link
Collaborator

This pull request brings in two unrelated changes:

  1. The Timer class, which is a very old tool from Noel Keen, had a clumsy way of initializing a global static list of Timers. I've refactored that to use a static member function in a new class (TimerRegistrar), which gives us a robust method of accessing this list of Timers. This is necessary in order to have more than one file that declares Timers.
  2. I've moved the NodeCoupling objects that do damaged node coupling to the Damage package (from Utilities).

jmikeowen added 4 commits June 21, 2021 09:57
@jmikeowen
Moved all the damage NodeCoupling algorithms from Utilities->Damage.
d0bf322 
This involved some fiddling with the python bindings.
@jmikeowen
Renaming DamagedNodeCoupling -> PairMaxDamageNodeCoupling, which is
a85f949 
consistent with the name of this option in the user interface.
@jmikeowen
Adding another canned LC build script.
9e5fb5e
@jmikeowen
Fixing the debacle of the Timer static TimerList nonsense. It's still
a631138 
ugly, but it works for declaring multiple timers in different
compilation units now.  This doesn't really belong in this branch, but
it'll go along for the ride.
@jmikeowen jmikeowen merged commit 1d1c410 into develop Jun 28, 2021
@jmikeowen jmikeowen deleted the feature/timer-fixes branch June 28, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishaZakharchanka MishaZakharchanka MishaZakharchanka approved these changes

@mdavis36 mdavis36 Awaiting requested review from mdavis36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikeowen @MishaZakharchanka