-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fsisph #77
Conversation
… option to sum over individual node lists
…ghting between pairs. Diffusion option added for rho and eps. Some damage modifications but not full functional
… option to sum over individual node lists
…ghting between pairs. Diffusion option added for rho and eps. Some damage modifications but not full functional
RZ and non solid versions commented out in case we add those in later
compatible formulation requires perfect i-j reversibility? ran into conservation issue when switching i/j would lead to slightly different evaluations of a loop cycle. Manifested as energy error on the first timestep cycle when numeric_limits was applied to the denomenator instead of the individual weights of the compatibility scheme
Using the inflow plane normal and point to center and orient the restricted inflow circle. Inflow radius initialized with max numeric limit. User can then set inflowRadius to activate the restricted inflow feature
fixed typo in Noh planar ats for FSISPH
Added Noh and Sod ats tests |
This is looking pretty good -- the main thing I'd like to see before we pull is an ATS test that has pass criteria to verify FSISPH is working correctly. Adding test conditions to the Noh/Sod tests is one possibility, but it'd be nice to have one of the test cases that FSISPH was designed for as well. |
Looks good -- I'm going to approve and merge this. I did find one testing problem -- the DiametralCompression.py test had an error in the ATS prescription. I fixed that and pushed the change, so we should be OK to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready.
SPH multimaterial module, here's a quick summary of the contents: