Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsisph #77

Merged
merged 111 commits into from
Aug 4, 2021
Merged

Fsisph #77

merged 111 commits into from
Aug 4, 2021

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Jul 21, 2021

SPH multimaterial module, here's a quick summary of the contents:

  1. SolidFSISPHHydroBase
    • solid hydro for problems with material property discontinuities
    • selectively apply density sum to individual nodelists
    • "consistent diffusion" option applies diffusion to eps and rho through the velocity gradient
    • diffusion options for specific thermal energy and density
    • modified damage implementation (material property reconstruction applied to damage front)
    • currently no RZ or fluidnodelists hydro classes
  2. SlideSurfaces
    • slide surface physics package (similar to AV implementation)
    • used to reduce artificial viscosity for slip interface conditions
    • based on interface normals between nodelists
  3. compatible energy treatment
    • pairwise thermal energy derivatives used as weights
    • operates on the difference between the conservative and calculated total pairwise work
    • allows pairwise therm energy derivatives to have opposite signs

…ghting between pairs. Diffusion option added for rho and eps. Some damage modifications but not full functional
…ghting between pairs. Diffusion option added for rho and eps. Some damage modifications but not full functional
jmpearl added 12 commits July 19, 2021 12:19
RZ and non solid versions commented out in case we add those in later
compatible formulation requires perfect i-j reversibility? ran into conservation issue when switching i/j would lead to slightly different evaluations of a loop cycle. Manifested as energy error on the first timestep cycle when numeric_limits was applied to the denomenator instead of the individual weights of the compatibility scheme
Using the inflow plane normal and point to center and orient the restricted inflow circle. Inflow radius initialized with max numeric limit. User can then set inflowRadius to activate the restricted inflow feature
@jmpearl jmpearl requested a review from jmikeowen July 29, 2021 17:43
jmpearl added 2 commits July 29, 2021 11:59
fixed typo in Noh planar ats for FSISPH
@jmpearl jmpearl marked this pull request as draft July 29, 2021 20:12
@jmpearl
Copy link
Collaborator Author

jmpearl commented Jul 29, 2021

Added Noh and Sod ats tests

@jmpearl jmpearl marked this pull request as ready for review July 29, 2021 22:54
@jmikeowen
Copy link
Collaborator

This is looking pretty good -- the main thing I'd like to see before we pull is an ATS test that has pass criteria to verify FSISPH is working correctly. Adding test conditions to the Noh/Sod tests is one possibility, but it'd be nice to have one of the test cases that FSISPH was designed for as well.

@jmikeowen
Copy link
Collaborator

Looks good -- I'm going to approve and merge this. I did find one testing problem -- the DiametralCompression.py test had an error in the ATS prescription. I fixed that and pushed the change, so we should be OK to go.

Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready.

@jmikeowen jmikeowen merged commit bb312b0 into develop Aug 4, 2021
@jmpearl jmpearl deleted the FSISPH branch September 28, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants